Dealing with dissapear track causing error. #475

cropse · 2024-11-22T18:25:23Z

In some scenarios, if a track is banned, deleted, or disappears, the playlist will contain an empty track (None). This error occurs as a result but can be easily fixed.
Error code:

  File "/config/custom_components/spotcast/__init__.py", line 360, in start_casting
    add_tracks_to_queue(client, searchResults[1:])
  File "/config/custom_components/spotcast/helpers.py", line 353, in add_tracks_to_queue
    filtered = list(filter(lambda x: x["type"] == "track", tracks))
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/spotcast/helpers.py", line 353, in <lambda>
    filtered = list(filter(lambda x: x["type"] == "track", tracks))
                                     ~^^^^^^^^
TypeError: 'NoneType' object is not subscriptable

Fix empty or banned track from recommanded track

fcusson

Small change just to go with the QC I'm trying to implement. Once you push the change, I'll merge for next release

custom_components/spotcast/helpers.py

fcusson · 2024-11-23T02:22:00Z

@cropse would you be able to provide an example of a case where this is happening, I want to test this edge case for the current v5 build

cropse · 2024-11-26T17:06:34Z

Sure, I think it's quite hard to reproduce since it's a really rare condition.

Open Discovery Weekly play list on Phone (This is probably only playlist which can be hiden so must test with this one)
click miner icon to hide the song
then log the tracks
Found data include None in the list.
Trimed e.g. looks like:

    {
        "collaborative": False,
        "description": "Discover &#x27;Mellow Music&#x27; 🎧 Perfect chill vibes for any time.  Updated [email protected]",
        "external_urls": {
            "spotify": "https://open.spotify.com/playlist/7ci4PEose2PtQPCOCCHKlP"
        },
        "href": "https://api.spotify.com/v1/playlists/7ci4PEose2PtQPCOCCHKlP",
        "id": "7ci4PEose2PtQPCOCCHKlP",
        "images": [
            {
                "height": None,
                "url": "https://image-cdn-ak.spotifycdn.com/image/ab67706c0000da84bcbfba1e69d1319f5dbee17f",
                "width": None,
            }
        ],
        "name": "Mellow music♭",
        "owner": {
            "display_name": "Ludwig van Beethoven",
            "external_urls": {
                "spotify": "https://open.spotify.com/user/315jlrz72kxu4bfycvwjlp6cl6k4"
            },
            "href": "https://api.spotify.com/v1/users/315jlrz72kxu4bfycvwjlp6cl6k4",
            "id": "315jlrz72kxu4bfycvwjlp6cl6k4",
            "type": "user",
            "uri": "spotify:user:315jlrz72kxu4bfycvwjlp6cl6k4",
        },
        "primary_color": None,
        "public": True,
        "snapshot_id": "AAAAfZh3P0uioQIrKFbUKri+JDEzGCxG",
        "tracks": {
            "href": "https://api.spotify.com/v1/playlists/7ci4PEose2PtQPCOCCHKlP/tracks",
            "total": 79,
        },
        "type": "playlist",
        "uri": "spotify:playlist:7ci4PEose2PtQPCOCCHKlP",
    },
    None,
    {
        "collaborative": False,
        "description": "[email protected]==The hottest pop tracks that are taking over the charts and social media. Refresh weekly so you will discover something new and exciting.!!",
        "external_urls": {
            "spotify": "https://open.spotify.com/playlist/6AZP6i1KUsgk4GtTlKdDdj"
        },
        "href": "https://api.spotify.com/v1/playlists/6AZP6i1KUsgk4GtTlKdDdj",
        "id": "6AZP6i1KUsgk4GtTlKdDdj",
        "images": [
            {
                "height": None,
                "url": "https://image-cdn-ak.spotifycdn.com/image/ab67706c0000da8448e5228e4b8f1b42e27962b5",
                "width": None,
            }
        ],
        "name": "Viral Vibes",
        "owner": {
            "display_name": "bella.7k",
            "external_urls": {
                "spotify": "https://open.spotify.com/user/314x7fx4s2zrotjoksiq65f7n2de"
            },
            "href": "https://api.spotify.com/v1/users/314x7fx4s2zrotjoksiq65f7n2de",
            "id": "314x7fx4s2zrotjoksiq65f7n2de",
            "type": "user",
            "uri": "spotify:user:314x7fx4s2zrotjoksiq65f7n2de",
        },
        "primary_color": None,
        "public": True,
        "snapshot_id": "AAAAiNu6f2goxoQdeGFThBZDlgXTX5PN",
        "tracks": {
            "href": "https://api.spotify.com/v1/playlists/6AZP6i1KUsgk4GtTlKdDdj/tracks",
            "total": 60,
        },
        "type": "playlist",
        "uri": "spotify:playlist:6AZP6i1KUsgk4GtTlKdDdj",
    },
]

I believe the song got removed should encountered similiar issue but it's hard to test IRL.

fcusson · 2024-11-26T18:11:51Z

for V5 I have a pager sytem that takes care of retrieving lists from the spotify API. I added a filter at the end to remove any NoneType object from the list doing so:

items = [x for x in items if x is not None]

That should automatically resolve the issue for any usecase

Update helpers.py

d6f6df7

Fix empty or banned track from recommanded track

fcusson requested changes Nov 23, 2024

View reviewed changes

custom_components/spotcast/helpers.py Outdated Show resolved Hide resolved

Update custom_components/spotcast/helpers.py

e3bb6f2

fcusson approved these changes Nov 26, 2024

View reviewed changes

fcusson merged commit 9ca0314 into fondberg:master Nov 26, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dealing with dissapear track causing error. #475

Dealing with dissapear track causing error. #475

cropse commented Nov 22, 2024 •

edited

Loading

fcusson left a comment

fcusson commented Nov 23, 2024

cropse commented Nov 26, 2024 •

edited

Loading

fcusson commented Nov 26, 2024

Dealing with dissapear track causing error. #475

Dealing with dissapear track causing error. #475

Conversation

cropse commented Nov 22, 2024 • edited Loading

fcusson left a comment

Choose a reason for hiding this comment

fcusson commented Nov 23, 2024

cropse commented Nov 26, 2024 • edited Loading

fcusson commented Nov 26, 2024

cropse commented Nov 22, 2024 •

edited

Loading

cropse commented Nov 26, 2024 •

edited

Loading